Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding RDS pricing #363

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Adding RDS pricing #363

merged 1 commit into from
Mar 20, 2024

Conversation

cweibel
Copy link
Contributor

@cweibel cweibel commented Mar 20, 2024 •
edited
Loading

Changes proposed in this pull request:

  • Adding RDS pricing based on published AWS RDS on-demand rates as of 3/20/2024
  • Ran dev smoke tests, they pass

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None.

@cweibel cweibel requested a review from a team March 20, 2024 20:47
@cweibel cweibel added this pull request to the merge queue Mar 20, 2024
Merged via the queue into main with commit 00dbf21 Mar 20, 2024
2 checks passed
@cweibel cweibel deleted the rds-pricing branch March 20, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcgottlieb rcgottlieb rcgottlieb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cweibel @rcgottlieb