Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Fixes https://github.com/cloud-gov/private/issues/2052
A previous broker bug that has since been fixed allowed updated databases to have a backup retention period of 0, which disables automated backups on RDS databases. Even though that bug has been fixed, there are some brokered databases which have
backup_retention_period: 0
stored in the broker's database, and the current broker logic allows that value to get re-applied to the RDS database on every update, thus re-disabling automated backups.This PR fixes two bugs:
Things to check
INFO
and debugging statements are written withlog.debug
or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.Security considerations
Our website states that automated backups are enabled and retained for 14 days on all brokered databases. Furthermore, if automated backups are disabled and there is a data loss scenario, then we as a platform may not be able to restore a customer's data.