You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If this belongs in the SDK then I can open a PR for us to talk about more specific issues such as whether or not to automate protobuf code generation or the complexity of the protobuf type juggling. I figured I'd start by asking whether or not this even belongs here or if this should go in a contrib space somewhere.
The text was updated successfully, but these errors were encountered:
Hi @kconwayinvision, thanks for the proposal. We would really love to see the protobuf format, what about starting with a PR for the implementation of format.Format?
For the datacodec implementation, let's figure it out after the format
Hey folks, I have an implementation of https://github.com/cloudevents/spec/blob/v1.0.1/protobuf-format.md that I'm looking to contribute. Before I open a PR, I figured I'd give folks a chance to see what is involved. I've put some code up for demonstration here: https://github.com/kconwayinvision/cloudevents-go-protobuf. It's a fairly straightforward implementation of
format.Format
,datacodec.Encoder
, anddatacodec.Decoder
. The real complexity is in implementing the requirement to use theProtoData
field when the format and data codec are both protobuf.If this belongs in the SDK then I can open a PR for us to talk about more specific issues such as whether or not to automate protobuf code generation or the complexity of the protobuf type juggling. I figured I'd start by asking whether or not this even belongs here or if this should go in a contrib space somewhere.
The text was updated successfully, but these errors were encountered: