Update Github workflows and Go dependencies #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embano1
force-pushed
the
deps_go122
branch
4 times, most recently
from
bd11d6c to
f647779
Compare
embano1
changed the title
|
@duglin for review |
duglin
reviewed
Oct 20, 2024
v2/protocol/http/write_request.go
Outdated
| @@ -86,7 +86,7 @@ func (b *httpRequestWriter) setBody(body io.Reader) error { | |||
| default: | |||
| // This is where we'd set it to -1 (at least | |||
| // if body != NoBody) to mean unknown, but | |||
| // that broke people during the Go 1.8 testing | |||
| // that broke people during the Go 1.8 testin2 | |||
There was a problem hiding this comment.
yeah, but not by me :)
I need to file a README update, lemme quickly address
Signed-off-by: Michael Gasch <15986659+embano1@users.noreply.github.com>
Signed-off-by: Michael Gasch <15986659+embano1@users.noreply.github.com>
duglin
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Github workflows and Go dependencies to more recent versions:
godirective in respective modules togo 1.22Note that I didn't feel the need to bump modules straight to
go 1.23because we don't use the latest language features andgo 1.22seemed sufficient/causing less compatibility issues (or warnings) for users < Go 1.22.