Reworking datacodec package #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n3wscott
reviewed
Mar 30, 2020
| @@ -66,7 +66,7 @@ func TestMarshal(t *testing.T) { | |||
| "exurl": source, | |||
| "extime": &now, | |||
| }, | |||
| want: toBytes(map[string]interface{}{ | |||
There was a problem hiding this comment.
In this file we need to add a test for each of the other encodings the sdk supports
|
LGTM We need to do a pass at xml testing, I am seeing a regression in the sdk (unrelated to this PR) |
…d from base64 Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Improved tests for base64 encoding case Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
slinkydeveloper
force-pushed
the
reworking_codec_package
branch
from
dbac0fe to
dd6bb7b
Compare
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
|
nice. LGTM, thanks for cleaning up. |
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
n3wscott
approved these changes
Mar 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR
datacodecpackage doesn't handle the base64 encoding, this is left to the event marshaller/unmarshaller which injects into theDatafield directly the decoded byte array.Also improves documentation of
SetDataandDataexplaining the various behaviours.