Fixed wrong result propagation #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
n3wscott
reviewed
Jun 29, 2020
| @@ -159,7 +159,7 @@ func (c *ceClient) Request(ctx context.Context, e event.Event) (*event.Event, pr | |||
| // If the protocol returns no error, it is an ACK on the request, but we had | |||
| // issues turning the response into an event, so make an ACK Result and pass | |||
| // down the ToEvent error as well. | |||
| err = fmt.Errorf("%w; failed to convert response into event: %s", protocol.ResultACK, rserr) | |||
| err = protocol.NewReceipt(true, "failed to convert response into event: %s\n%w", rserr.Error(), err) | |||
There was a problem hiding this comment.
ah, I see, we are dropping the err type and we can't understand if it is a special error. got it.
LGTM
n3wscott
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
Requestwas not propagating correctly the result. This fixes itSigned-off-by: Francesco Guardiani francescoguard@gmail.com