Fixing nil http.Result ack compare #559
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #558
I found two issues in the codebase:
!IsACK
to understand if it should process the response into a CloudEvent. The thinking is if it was not an ACK, then there must not be any event to parse. This logic is incorrect, it should test forIsUndelivered
. If the event never left, then it can't have a response.Result
s are not treated as ACK.Running the
samples/http/responder
andsamples/http/requester
now get the expected output:Signed-off-by: Scott Nichols snichols@vmware.com