Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/Azure/go-amqp version to 0.13.7 #687

Merged
merged 1 commit into from
May 18, 2021

Conversation

oleg-kulyk
Copy link
Contributor

The change updates the version of github.com/Azure/go-amqp to 0.13.7 (from 0.12.7) - there's a breaking change inside with how Ack and Nack are handled for amqp.

This is similar to #676 (but that one is for 0.13.6 and changes Receive). It does of course fix #673

Signed-off-by: Oleg Kulyk <oleg.kulyk@checkmarx.com>
@n3wscott
Copy link
Member

NATSS is the flake, we are having issues with NATSS. Not your problem. Thanks for the PR!

LGTM

@n3wscott n3wscott merged commit 27c75f8 into cloudevents:main May 18, 2021
@oleg-kulyk oleg-kulyk deleted the 673-update-amqp-version branch May 19, 2021 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AMQP does't work
2 participants