New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nats integration tests #710

Merged

n3wscott merged 1 commit into cloudevents:main from benmoss:fix-nats

Aug 18, 2021

Contributor

benmoss commented Aug 18, 2021 •

edited

Loading

Not really sure why this was broken, I was getting this error when running these locally:

go test -v -parallel 1 -timeout 10m -race -covermode=atomic -coverprofile=coverage.tmp -coverpkg "$COVERPKG" github.com/cloudevents/sdk-go/test/integration/nats
go: github.com/cloudevents/sdk-go/protocol/nats/v2@v2.5.0 requires
        github.com/nats-io/nats-server/v2@v2.3.4: missing go.sum entry; to add it:
        go mod download github.com/nats-io/nats-server/v2

I ran go mod tidy and it made these changes to go.mod and go.sum. I bumped the nats image just since it seemed out of date.


          Fix nats integration tests

31d1240

Signed-off-by: Ben Moss <benm@vmware.com>

benmoss force-pushed the fix-nats branch from fde0125 to 31d1240 Compare

August 18, 2021 20:39

Member

n3wscott commented Aug 18, 2021

GREEN again!!
Thanks Ben!!

LGTM

n3wscott merged commit 70febdc into cloudevents:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet