736 feat pubsub subscription filter #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n3wscott
approved these changes
Nov 24, 2021
|
It looks like you need to sign the commit to pass DCO, but LGTM other than that |
Signed-off-by: Iker Rejano <irejanodev@gmail.com>
Included filter value in connection struct to the creation method Signed-off-by: Iker Rejano <irejanodev@gmail.com>
Signed-off-by: Iker Rejano <irejanodev@gmail.com>
irejanodev
force-pushed
the
736-feat-pubsub-subscription-filter
branch
from
720cd68 to
69f8e60
Compare
Yes! thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My apologies, I forgot to include the filter value in the
Connectionstruct to the creation method.This fix allows server filtering as the pubsub implementation.
CC/ @n3wscott