Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement non-standard SubtleCrypto timingSafeEqual #542

Merged
merged 3 commits into from
Mar 22, 2023

Conversation

DaniFoldi
Copy link
Contributor

workerd implements a non-standard extension method timingSafeEqual to the Web Crypto API under Subtle Crypto. Fortunately, node also provides a similar implementation, under the regular crypto.

This PR is not concerned about the safety of the implementation, as miniflare is intended for local development purposes only.

Marking as draft as the types for crypto.subtle come from node's types in miniflare and typecheck fails. @mrbbot how should we approach overriding the type for the crypto module? The method exists in workerd and workers-types.

@changeset-bot
Copy link

changeset-bot bot commented Mar 22, 2023

⚠️ No Changeset found

Latest commit: 2b07933

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mrbbot
Copy link
Contributor

mrbbot commented Mar 22, 2023

We used to have a types/crypto.d.ts file for these non-standard extensions:

declare module "crypto" {
namespace webcrypto {

Anything non-standard in Worker's crypto was added to the webcrypto namespace. Maybe add a trimmed down version of that file back?

@DaniFoldi DaniFoldi marked this pull request as ready for review March 22, 2023 13:41
Co-authored-by: MrBBot <me@mrbbot.dev>
@mrbbot mrbbot merged commit f05a97e into cloudflare:master Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants