Implement non-standard SubtleCrypto timingSafeEqual #542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workerd
implements a non-standard extension methodtimingSafeEqual
to the Web Crypto API under Subtle Crypto. Fortunately, node also provides a similar implementation, under the regularcrypto
.This PR is not concerned about the safety of the implementation, as miniflare is intended for local development purposes only.
Marking as draft as the types for crypto.subtle come from node's types in miniflare and typecheck fails. @mrbbot how should we approach overriding the type for the crypto module? The method exists in workerd and workers-types.