[Miniflare 3] Re-implement Cache gateway using new storage system #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This attempts to fix an issue where tests would pass, but AVA would hang. Step-through debugging doesn't seem to work when the `workerThreads` option is enabled either.
|
Closes DEVX-590
mrbbot
force-pushed
the
tre-new-storage-cache
branch
from
51cf124 to
727b069
Compare
JacobMGEvans
approved these changes
May 2, 2023
Add test for parsing Cache API messages from `workerd`
Remove extraneous `as`s
Extract parameters to `getMatchResponse()` into separate type
Remove `log` member on `CacheGateway`
Assert `resHeaders` created as opposed to `??=`
penalosa
approved these changes
May 9, 2023
penalosa
approved these changes
May 9, 2023
penalosa
approved these changes
May 9, 2023
penalosa
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #555, and re-implements the Cache gateway using the new storage system. Specifically, it uses the same abstract expiring-key-value-metadata store as the KV gateway. The gateway now uses streams all the way from the incoming request to the blob store. 🙂
Whilst implementing this, I noticed tests passing but hanging. 😕 I'm hoping the
avabump should've fixed this. You may wish to review this in isolation. 👍 (alternatively fixing #532 will mean we don't need to use AVA shared workers for getting ports, which seem to be the buggy component)Closes DEVX-590