Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Miniflare 3] Allow custom upstreams to be specified #568

Merged
merged 1 commit into from
May 15, 2023

Conversation

mrbbot
Copy link
Contributor

@mrbbot mrbbot commented May 10, 2023

This adds back Miniflare 2's upstream option, which allows you to customise the origin of incoming requests to the Worker. This is useful when implementing proxy servers with Workers. Wrangler exposes this option as the --local-upstream flag, so we'd like to support this in Miniflare 3 to avoid regressing when we graduate.

Closes cloudflare/workers-sdk#2821
Closes DEVX-628

(to be merged after #566)

@mrbbot mrbbot added the tre Relating to Miniflare 3 label May 10, 2023
@mrbbot mrbbot requested a review from a team May 10, 2023 14:55
@changeset-bot
Copy link

changeset-bot bot commented May 10, 2023

⚠️ No Changeset found

Latest commit: e2c8bcf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Base automatically changed from tre-queues to tre May 12, 2023 16:24
@mrbbot mrbbot force-pushed the tre-custom-upstream branch from b0a5439 to 1ad0d2a Compare May 12, 2023 16:37
This adds back Miniflare 2's `upstream` option, which allows you to
customise the origin of incoming requests to the Worker. This is
useful when implementing proxy servers with Workers. Wrangler exposes
this option as the `--local-upstream` flag, so we'd like to support
this in Miniflare 3 to avoid regressing when we graduate.

Closes cloudflare/workers-sdk#2821
Closes DEVX-628
@mrbbot mrbbot force-pushed the tre-custom-upstream branch from 1ad0d2a to e2c8bcf Compare May 15, 2023 15:02
@mrbbot mrbbot merged commit 1416b1d into tre May 15, 2023
@mrbbot mrbbot deleted the tre-custom-upstream branch May 15, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tre Relating to Miniflare 3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants