[Miniflare 3] Ignore node: and cloudflare: modules when collecting modules
#569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RamIdeas
reviewed
May 11, 2023
packages/tre/test/index.spec.ts
Outdated
| port: await getPort(), | ||
| modules: true, | ||
| compatibilityFlags: ["nodejs_compat"], | ||
| script: `import { Buffer } from "node:buffer"; |
There was a problem hiding this comment.
Is there a "cloudflare:" import you can also add to this test script?
There was a problem hiding this comment.
Answer: not available to import yet, but will be soon
LGTM
RamIdeas
approved these changes
May 11, 2023
Previously, Miniflare would complain when specifying a `script`/ `scriptPath` that used `node:`/`cloudflare:` imports with `modules: true` set. This change updates Miniflare's module collector to ignore them, as they're automatically included by `workerd`.
mrbbot
force-pushed
the
tre-node-cloudflare-modules
branch
from
66c1348 to
bd9277b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Miniflare would complain when specifying a
script/scriptPaththat usednode:/cloudflare:imports withmodules: trueset. This change updates Miniflare's module collector to ignore them, as they're automatically included byworkerd.