Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Miniflare 3] Bump workerd to 1.20230512.0 #575

Merged
merged 2 commits into from
May 15, 2023
Merged

Conversation

mrbbot
Copy link
Contributor

@mrbbot mrbbot commented May 12, 2023

This PR bumps workerd to version 1.20230511.0, adding support for multiple/weak/wildcard R2 ETags, and getting listening ports from the new --control-fd flag. The R2 ETag stuff should really be in a separate PR, but this version changes the schema for R2 loopback requests, breaking our existing gateway. See cloudflare/workerd#563. The other change here is waiting for control messages using the new --control-fd flag. This signals when workerd is ready to receive requests, and the port it's listening on. This allows us to pass port 0 directly to workerd, and have it allocate a free port, preventing races. The default port has been changed to 0, since that makes more sense for an API. It also allows us to remove the repeated readiness probes. 🎉

@mrbbot mrbbot added the tre Relating to Miniflare 3 label May 12, 2023
@mrbbot mrbbot requested a review from a team May 12, 2023 17:05
@changeset-bot
Copy link

changeset-bot bot commented May 12, 2023

⚠️ No Changeset found

Latest commit: 34f810a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mrbbot mrbbot force-pushed the tre-workerd-2023-05-11 branch from dbd738f to 0460c89 Compare May 15, 2023 12:20
Wait for control messages using the new `--control-fd` flag for
signalling when `workerd` is ready to receive requests, and the port
it's listening on. This allows us to pass port `0` directly to
workerd, and have it allocate a free port, preventing races. It also
allows us to remove the repeated readiness probes. 🎉
@mrbbot mrbbot changed the title [Miniflare 3] Bump workerd to 1.20230511.0 [Miniflare 3] Bump workerd to 1.20230512.0 May 15, 2023
@mrbbot mrbbot force-pushed the tre-workerd-2023-05-11 branch from 0460c89 to 34f810a Compare May 15, 2023 13:59
@mrbbot mrbbot merged commit 330136f into tre May 15, 2023
@mrbbot mrbbot deleted the tre-workerd-2023-05-11 branch May 15, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tre Relating to Miniflare 3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants