[Miniflare 3] Use http.STATUS_CODES for logging status text
#616
Conversation
|
| @@ -144,7 +144,6 @@ function maybeLogRequest( | |||
| headers: { "Content-Type": "application/json" }, | |||
| body: JSON.stringify({ | |||
| status: response.status, | |||
| statusText: response.statusText, | |||
There was a problem hiding this comment.
Is there any scenario where response.statusText is different to what would be retrieved from http.STATUS_CODES? I.e. should we try using this first and fall back to the lookup if not available?
There was a problem hiding this comment.
Technically, you can specify any value you want I think. Trying the value then falling back seems like a good idea. 🙂 👍
mrbbot
force-pushed
the
bcoll/tre-status-text-from-http
branch
from
95ed886 to
811e9ae
Compare
Some responses, especially those from custom services, don't have a `statusText`. This means some logs only include a status code. We can derive the text from just the code using the `http.STATUS_CODES` constants built into Node.
mrbbot
force-pushed
the
bcoll/tre-status-text-from-http
branch
from
811e9ae to
1868834
Compare
Some responses, especially those from custom services, don't have a
statusText. This means some logs only include a status code. We can derive the text from just the code using thehttp.STATUS_CODESconstants built into Node.