Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "onConnectionError" notification events #22

Closed
itvby opened this issue Jul 19, 2023 · 2 comments
Closed

Add "onConnectionError" notification events #22

itvby opened this issue Jul 19, 2023 · 2 comments

Comments

@itvby
Copy link

itvby commented Jul 19, 2023 •
edited
Loading

Hi! Thanks for your work.

It would be a good idea to add "onConnectionError" to events.

Sometimes the application crashes due to an error calling the this.#loadEngine.stop() method because this.#loadEngine is not initialized. There is no way to catch this error.

photo_2023-07-20_16-07-06

Thanks!
@bekmuradov
Copy link

I had the same issue, and I managed to solve it by making changes to the BandwidthMeasurementEngine class.
If you're interested in the fix and want to see the specific changes, you can find them in this pull request: https://github.com/cloudflare/speedtest/pull/24/files

@vasturiano vasturiano mentioned this issue Sep 11, 2023
Merged
@vasturiano
Copy link
Contributor

@itvby thanks for reaching out.

This bug has been fixed, and a new onError method has also been added to the module schema. Please upgrade to v1.3.0 to get the fix.

More details on the PR: #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vasturiano @itvby @bekmuradov