Support for load balancer origin steering #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gofish
force-pushed
the
jfishman/load-balancing/origin-steering
branch
from
8c07921 to
5d837d6
Compare
jacobbednarz
reviewed
Oct 7, 2021
| Schema: map[string]*schema.Schema{ | ||
| "policy": { | ||
| Type: schema.TypeString, | ||
| Default: "", |
There was a problem hiding this comment.
this doesn't seem to line up with your documentation below. which do we want here?
The **origin_steering** block supports:
* `policy` - (Optional) Either "random" (default) or "hash".
|
could you please add a CHANGELOG entry for this PR based on the changelog process doc? acceptance tests look good |
Initial support for load balancer pool origin steering policies. See cloudflare/cloudflare-go#722.
gofish
force-pushed
the
jfishman/load-balancing/origin-steering
branch
from
5d837d6 to
1e02e2b
Compare
|
boom! nice work 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial support for load balancer pool origin steering policies.
See cloudflare/cloudflare-go#722.