Add worker kv

[nrf110]

Support Workers KV Pairs. This should resolve #565

Proposed resource syntax:
resource "cloudflare_workers_kv" "example_kv" { namespace_id = cloudflare_workers_kv_namespace.example_ns.id key = "test-key" value = "some value" }

[jacobbednarz]

Looks like integration tests are failing for this one:

------- Stdout: -------
=== RUN   TestAccCloudflareWorkersKV_Basic
=== PAUSE TestAccCloudflareWorkersKV_Basic
=== CONT  TestAccCloudflareWorkersKV_Basic
--- FAIL: TestAccCloudflareWorkersKV_Basic (0.00s)
    testing.go:654: Step 0 error: 4 problems:
        
        - Invalid multi-line string: On /opt/teamcity-agent/temp/buildTmp/tf-test760257884/main.tf line 3: Quoted strings may not be split over multiple lines. To produce a multi-line string, either use the \n escape to represent a newline character or use the "heredoc" multi-line template syntax.
        - Invalid multi-line string: On /opt/teamcity-agent/temp/buildTmp/tf-test760257884/main.tf line 4: Quoted strings may not be split over multiple lines. To produce a multi-line string, either use the \n escape to represent a newline character or use the "heredoc" multi-line template syntax.
        - Invalid multi-line string: On /opt/teamcity-agent/temp/buildTmp/tf-test760257884/main.tf line 5: Quoted strings may not be split over multiple lines. To produce a multi-line string, either use the \n escape to represent a newline character or use the "heredoc" multi-line template syntax.
        - Unterminated template string: On /opt/teamcity-agent/temp/buildTmp/tf-test760257884/main.tf line 3: No closing marker was found for the string.
FAIL

[jacobbednarz]

All of the Worker KV methods require setting api.AccountID however we're not setting it or documenting it as a required configuration parameter. How does it work at the moment?

[nrf110]

None of the methods have a parameter for the account ID, it is set on the cloudflare.API client when the provider configures it. This is identical to how the existing cloudflare_workers_kv_namespace resource works, but I can add it to the documentation if needed.

[nrf110]

Added a note in the docs that setting account_id on the provider, or the CLOUDFLARE_ACCOUNT_ID environment variable is necessary to use this. Does that cover the requirement?

[jacobbednarz]

I see your create + update methods are pretty similar. In some resources where this is also the case, the Create and Update just share the one method. Up to you as I don't mind either way.

[nrf110]

Is there any harm in calling d.SetId in an Update method? That's the main difference between them. I'm all for saving some code if that isn't an issue.

[nrf110]

These have been combined into one method.

[nrf110]

@jacobbednarz I think I've addressed all of the feedback so far. Anything else we need before this can be approved?

[patryk]

Thanks @nrf110 for the PR!