SQC-333: Revert previous changes #3148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit reverts 1149737. The sslmode change in the previous commit does not work as expected. Connection attempts time out, presumably getting hung while negotiating SSL upgrade. Revert this change until we have the bandwidth to attempt it again.
jasnell
approved these changes
Nov 20, 2024
jasnell
reviewed
Nov 20, 2024
| @@ -80,7 +80,7 @@ uint16_t Hyperdrive::getPort() { | |||
|
|
|||
| kj::String Hyperdrive::getConnectionString() { | |||
| return kj::str(getScheme(), "://", getUser(), ":", getPassword(), "@", getHost(), ":", getPort(), | |||
| "/", getDatabase(), "?sslmode=prefer"); | |||
There was a problem hiding this comment.
you might consider putting the change behind an autogate so that the availability of the change can be rolled out with a salt gate instead of needing a new release.
There was a problem hiding this comment.
I'll have to explore that, I haven't spent a ton of time in the core edgeworker repos yet. Thanks for the tip!
I think this particular change should be okay going out with the next release, though.
There was a problem hiding this comment.
Good to patch this now and have a proper fix in the next release, customers have to install specific version. All local development is broken right now
anonrig
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reverts 1149737. The sslmode change in the previous commit does not work as expected. Connection attempts time out, presumably getting hung while negotiating SSL upgrade. Revert this change until we have the bandwidth to attempt it again.