Skip to content

Conversation

@vicb
Copy link
Contributor

@vicb vicb commented Nov 20, 2025

Factor a common pattern of testing property types.

One benefit is that it prints a clear error message on mismatch.


  • Tests
    • Tests included
    • Tests not necessary because: refactoring
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: refactoring
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: refactoring

@vicb vicb requested a review from a team as a code owner November 20, 2025 08:21
@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2025

⚠️ No Changeset found

Latest commit: 5c6bf3c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 20, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@11354

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@11354

miniflare

npm i https://pkg.pr.new/miniflare@11354

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@11354

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@11354

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@11354

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@11354

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@11354

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@11354

wrangler

npm i https://pkg.pr.new/wrangler@11354

commit: 5c6bf3c

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Nov 20, 2025
@vicb vicb changed the base branch from main to devin/1760951437-node-wasi November 20, 2025 10:56
Base automatically changed from devin/1760951437-node-wasi to main November 20, 2025 12:04
@dario-piotrowicz dario-piotrowicz merged commit 8ba8d99 into main Nov 20, 2025
33 of 35 checks passed
@dario-piotrowicz dario-piotrowicz deleted the vicb/unenv-e2e branch November 20, 2025 12:06
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants