Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApplicationManifestUtilsV3#write is not threadsafe #1245

Open
LitschiW opened this issue Oct 11, 2024 · 0 comments · May be fixed by #1246
Open

ApplicationManifestUtilsV3#write is not threadsafe #1245

LitschiW opened this issue Oct 11, 2024 · 0 comments · May be fixed by #1246

Comments

@LitschiW
Copy link

LitschiW commented Oct 11, 2024

The method ApplicationManifestUtilsV3#write uses a static snakeyaml Yaml dumper to write all manifests into a byte array. This operation is inheritly not threadsafe, as the deserializer is not.

This in itself may not a be problem. However, when using Applications#pushManifestv3 to push multiple Apps in parallel this can cause issues that manifest in the form of

  • Bad request: Manifest does not support Anchors and Aliases or
  • java.lang.NullPointerException: Nodes must be provided.

Snakeyaml recommends to create a singe instance per thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant