make use of utc time zone and appease linters

Author: iaftab-alam

lib/diego/client.rb

@@ -164,18 +164,18 @@ def actual_lrps_by_process_guid(process_guid)
     def with_request_error_handling
       delay = 0.25
       max_delay = 5
-      retry_until = Time.now + 60 # retry for 1 minute from now
+      retry_until = Time.now.utc + 60 # retry for 1 minute from now
       factor = 2
 
       begin
         yield
       rescue StandardError => e
-        if Time.now > retry_until
+        if Time.now.utc > retry_until
           @logger.error('Unable to establish a connection to diego backend, no more retries, raising an exception.')
           raise RequestError.new(e.message)
         else
           sleep_time = [delay, max_delay].min
-          @logger.info("Attempting to connect to the diego backend. Total #{(retry_until - Time.now).round(2)} seconds remaining. Next retry after #{sleep_time} seconds delay.")
+          @logger.info("Attempting to connect to the diego backend. Total #{(retry_until - Time.now.utc).round(2)} seconds remaining. Next retry after #{sleep_time} seconds.")
           sleep(sleep_time)
           delay *= factor
           retry

spec/diego/client_spec.rb

@@ -806,7 +806,7 @@ module Diego
           expect do
             subject.with_request_error_handling do
               attempts += 1
-              Timecop.travel(Time.now + 50)
+              Timecop.travel(Time.now.utc + 50)
               raise 'Error!'
             end
           end.to raise_error(RequestError, 'Error!')
@@ -818,7 +818,7 @@ module Diego
         end
 
         it 'stops retrying after 60 seconds and raises an exception' do
-          start_time = Time.now
+          start_time = Time.now.utc
           Timecop.freeze do
             expect do
               subject.with_request_error_handling do
@@ -861,14 +861,14 @@ module Diego
 
         it 'raises an error after 17 attempts in approximately 1 minute when each yield call immediately' do
           attempts = 0
-          start_time = Time.now
+          start_time = Time.now.utc
           expect do
             subject.with_request_error_handling do
               attempts += 1
               raise RequestError
             end
           end.to raise_error(RequestError)
-          end_time = Time.now
+          end_time = Time.now.utc
           duration = end_time.to_f - start_time.to_f
 
           expect(attempts).to be_within(1).of(17)