Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #207, supplying AWS_DEFAULT_REGION fixes v0.12 tf validate #208

Closed
wants to merge 9 commits into from
Closed

Fixes #207, supplying AWS_DEFAULT_REGION fixes v0.12 tf validate #208

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
052f257
Fixes #207, supplying AWS_DEFAULT_REGION fixes v0.12 `tf validate`
Gowiem Apr 24, 2020
170da25
Update # 1 to include env localized to target
Gowiem May 7, 2020
12ff852
Update # 2 to include env localized to target
Gowiem May 7, 2020
162db43
Merge branch 'master' into fix-terraform-validate-on-0.12
Gowiem May 7, 2020
0a21baa
Merge branch 'master' into fix-terraform-validate-on-0.12
Gowiem Jun 18, 2020
bf98d22
Merge branch 'master' into fix-terraform-validate-on-0.12
Gowiem Jun 27, 2020
300b0d6
Merge branch 'master' into fix-terraform-validate-on-0.12
Gowiem Aug 14, 2020
dd354cc
Merge branch 'master' into fix-terraform-validate-on-0.12
Gowiem Aug 18, 2020
fc502d5
Merge branch 'master' into fix-terraform-validate-on-0.12
Gowiem Nov 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion modules/terraform/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,12 @@ terraform/get-modules:
@$(TERRAFORM) init -get -backend=false -input=false >/dev/null

## Basic terraform sanity check
## For v0.12.x, we supply a random region to AWS_DEFAULT_REGION so as to fix the
## "The argument "region" is required" error when validating independent modules.
## More info: https://github.com/hashicorp/terraform/issues/21408#issuecomment-495746582
terraform/validate:
Gowiem marked this conversation as resolved.
Show resolved Hide resolved
ifeq ("12","$(word 2, $(subst ., ,$(TERRAFORM_VERSION)))")
@echo "Terraform 0.12 does not support validate without skipping variables"
@AWS_DEFAULT_REGION="us-west-2" $(TERRAFORM) validate
Gowiem marked this conversation as resolved.
Show resolved Hide resolved
else
@$(TERRAFORM) validate -check-variables=false
endif
Expand Down