From 5569526d193a34c398581febcce4a1c698c4c6c0 Mon Sep 17 00:00:00 2001 From: aknysh Date: Wed, 21 Feb 2018 22:43:51 -0500 Subject: [PATCH] Fix `docker:login` --- modules/docker/Makefile.hub | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/modules/docker/Makefile.hub b/modules/docker/Makefile.hub index dd6e3287..1037fe44 100644 --- a/modules/docker/Makefile.hub +++ b/modules/docker/Makefile.hub @@ -2,8 +2,8 @@ ## Use DOCKER_HUB_USERNAME and DOCKER_HUB_PASSWORD env variables to pass credentials ## Login into docker hub docker\:login: $(DOCKER) - @if [ -n "$DOCKER" ] && [ -n "$DOCKER_HUB_USERNAME" ] && [ -n "$DOCKER_HUB_PASSWORD" ]; then\ - $(DOCKER) login --username="$DOCKER_HUB_USERNAME" --password="$DOCKER_HUB_PASSWORD";\ + @if [ -n "$(DOCKER_HUB_USERNAME)" ] && [ -n "$(DOCKER_HUB_PASSWORD)" ]; then \ + $(DOCKER) login --username="$(DOCKER_HUB_USERNAME)" --password="$(DOCKER_HUB_PASSWORD)"; \ else \ echo "Skipping docker:login. Docker credentials (DOCKER_HUB_USERNAME or DOCKER_HUB_PASSWORD) are not set"; \ fi;