Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: private policies cannot use wildcard principal #311

Merged
merged 4 commits into from
Jun 10, 2024
Merged

fix: private policies cannot use wildcard principal #311

merged 4 commits into from
Jun 10, 2024

Conversation

dudymas
Copy link
Contributor

@dudymas dudymas commented Jun 9, 2024

what

  • fix(s3_website_origin/principals): adjust for private buckets
  • fix(dns/zone_id): should be null if not specified

why

  • Attempting to set the principal to ["*"] (a wildcard) is blocked by the
    latest public access policy validation for S3
  • DNS zone name is not used for Route53 Zone lookup unless the zone_id is
    null

@dudymas dudymas requested review from a team as code owners June 9, 2024 16:53
@dudymas dudymas requested review from kevcube and RoseSecurity June 9, 2024 16:53
@mergify mergify bot added the triage Needs triage label Jun 9, 2024
@dudymas
Copy link
Contributor Author

dudymas commented Jun 9, 2024 •
edited by github-actions bot
Loading

These changes were released in v0.95.0.

@dudymas
Copy link
Contributor Author

dudymas commented Jun 9, 2024

/terratest

@mergify mergify bot removed the triage Needs triage label Jun 10, 2024
@dudymas dudymas merged commit 239f4ea into main Jun 10, 2024
25 checks passed
@dudymas dudymas deleted the fix/s3-get-policy/support-private-origin branch June 10, 2024 19:20
@dudymas dudymas mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benbentwo Benbentwo Benbentwo approved these changes

@kevcube kevcube Awaiting requested review from kevcube kevcube is a code owner automatically assigned from cloudposse/contributors

@RoseSecurity RoseSecurity Awaiting requested review from RoseSecurity RoseSecurity is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dudymas @Benbentwo