Skip to content

Commit

Permalink
[alb-controller] Make default_ingress_ip_address_type default to `ipv…
Browse files Browse the repository at this point in the history
…4` (#1070)
  • Loading branch information
Nuru authored Jun 20, 2024
1 parent b93cf82 commit 68924b6
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 3 deletions.
17 changes: 16 additions & 1 deletion modules/eks/alb-controller/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,19 @@
## PR [#821](https://github.com/cloudposse/terraform-aws-components/pull/821)
## PR 1070

PR [#1070](https://github.com/cloudposse/terraform-aws-components/pull/1070)

Change default for `default_ingress_ip_address_type` from `dualstack` to `ipv4`. When `dualstack` is configured, the
Ingress will fail if the VPC does not have an IPv6 CIDR block, which is still a common case. When `ipv4` is configured,
the Ingress will work with only an IPv4 CIDR block, and simply will not use IPv6 if it exists. This makes `ipv4` the
more conservative default.

## Release 1.432.0

Better support for Kubeconfig authentication

## Release 1.289.1

PR [#821](https://github.com/cloudposse/terraform-aws-components/pull/821)

### Update IAM Policy and Change How it is Managed

Expand Down
2 changes: 1 addition & 1 deletion modules/eks/alb-controller/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ components:
| <a name="input_default_ingress_class_name"></a> [default\_ingress\_class\_name](#input\_default\_ingress\_class\_name) | Class name for default ingress | `string` | `"default"` | no |
| <a name="input_default_ingress_enabled"></a> [default\_ingress\_enabled](#input\_default\_ingress\_enabled) | Set `true` to deploy a default IngressClass. There should only be one default per cluster. | `bool` | `true` | no |
| <a name="input_default_ingress_group"></a> [default\_ingress\_group](#input\_default\_ingress\_group) | Group name for default ingress | `string` | `"common"` | no |
| <a name="input_default_ingress_ip_address_type"></a> [default\_ingress\_ip\_address\_type](#input\_default\_ingress\_ip\_address\_type) | IP address type for default ingress, one of `ipv4` or `dualstack`. | `string` | `"dualstack"` | no |
| <a name="input_default_ingress_ip_address_type"></a> [default\_ingress\_ip\_address\_type](#input\_default\_ingress\_ip\_address\_type) | IP address type for default ingress, one of `ipv4` or `dualstack`. | `string` | `"ipv4"` | no |
| <a name="input_default_ingress_load_balancer_attributes"></a> [default\_ingress\_load\_balancer\_attributes](#input\_default\_ingress\_load\_balancer\_attributes) | A list of load balancer attributes to apply to the default ingress load balancer.<br>See [Load Balancer Attributes](https://docs.aws.amazon.com/elasticloadbalancing/latest/application/application-load-balancers.html#load-balancer-attributes). | `list(object({ key = string, value = string }))` | `[]` | no |
| <a name="input_default_ingress_scheme"></a> [default\_ingress\_scheme](#input\_default\_ingress\_scheme) | Scheme for default ingress, one of `internet-facing` or `internal`. | `string` | `"internet-facing"` | no |
| <a name="input_delimiter"></a> [delimiter](#input\_delimiter) | Delimiter to be used between ID elements.<br>Defaults to `-` (hyphen). Set to `""` to use no delimiter at all. | `string` | `null` | no |
Expand Down
2 changes: 1 addition & 1 deletion modules/eks/alb-controller/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ variable "default_ingress_scheme" {
variable "default_ingress_ip_address_type" {
type = string
description = "IP address type for default ingress, one of `ipv4` or `dualstack`."
default = "dualstack"
default = "ipv4"

validation {
condition = contains(["ipv4", "dualstack"], var.default_ingress_ip_address_type)
Expand Down

0 comments on commit 68924b6

Please sign in to comment.