-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Grafana Prometheus and Loki #1054
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milldr
commented
May 30, 2024
milldr
commented
May 30, 2024
milldr
commented
May 30, 2024
milldr
commented
May 31, 2024
osterman
reviewed
Jun 5, 2024
osterman
reviewed
Jun 5, 2024
dudymas
reviewed
Jun 5, 2024
osterman
reviewed
Jun 5, 2024
osterman
reviewed
Jun 5, 2024
Benbentwo
previously approved these changes
Jun 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some comments here and stored in my head, but I think this PR is tightly coupled with a lot of other changes, and would be best changed in a follow up PR or as the component and modules naturally evolve
osterman
reviewed
Jun 5, 2024
Benbentwo
approved these changes
Jun 11, 2024
These changes were released in v1.462.0. |
goruha
pushed a commit
to cloudposse-terraform-components/aws-eks-loki
that referenced
this pull request
Nov 27, 2024
goruha
pushed a commit
to cloudposse-terraform-components/aws-eks-prometheus-scraper
that referenced
this pull request
Nov 27, 2024
goruha
pushed a commit
to cloudposse-terraform-components/aws-eks-promtail
that referenced
this pull request
Nov 27, 2024
goruha
pushed a commit
to cloudposse-terraform-components/aws-managed-grafana-api-key
that referenced
this pull request
Nov 27, 2024
goruha
pushed a commit
to cloudposse-terraform-components/aws-managed-grafana-dashboard
that referenced
this pull request
Nov 27, 2024
goruha
pushed a commit
to cloudposse-terraform-components/aws-managed-grafana-data-source-loki
that referenced
this pull request
Nov 27, 2024
goruha
pushed a commit
to cloudposse-terraform-components/aws-managed-grafana-data-source-managed-prometheus
that referenced
this pull request
Nov 27, 2024
goruha
pushed a commit
to cloudposse-terraform-components/aws-managed-grafana-workspace
that referenced
this pull request
Nov 27, 2024
goruha
pushed a commit
to cloudposse-terraform-components/aws-managed-prometheus-workspace
that referenced
this pull request
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
managed-grafana
sub components are used for setting up complete infrastructure as code provisioning of the monitoring systemreferences