Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aurora-postgres): backup configs #1063

Merged
merged 2 commits into from
Jun 11, 2024
Merged

feat(aurora-postgres): backup configs #1063

merged 2 commits into from
Jun 11, 2024

Conversation

oycyc
Copy link
Contributor

@oycyc oycyc commented Jun 9, 2024

what

The CloudPosse RDS cluster module https://github.com/cloudposse/terraform-aws-rds-cluster has these backup configurations that would be helpful to have!

why

  1. Allows me to set backup configurations
  2. Without these inputs, the cluster is forced to use the default configs from the module
  3. Allows me to set these variable values to null or empty when I don't want any backing up happening
  4. Without these inputs to set it as empty values, there's a conflict when using RDS clusters with AWS Backup plans because the RDS resource maintains its backup values, while AWS Backup plans wants other values.

references

  • CloudPosse's RDS module
image - AWS Backup conflict with default backup values unless explictly set https://github.com/hashicorp/terraform-provider-aws/issues/33465

@oycyc oycyc requested review from a team as code owners June 9, 2024 15:56
Copy link
Member

@Benbentwo Benbentwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this!

@oycyc
Copy link
Contributor Author

oycyc commented Jun 11, 2024

These changes were released in v1.461.0.

@Benbentwo Benbentwo self-assigned this Jun 11, 2024
@Benbentwo
Copy link
Member

Benbentwo commented Jun 11, 2024

Thanks for re-commenting, I got distracted with slack and other GH issues. Re-ran everything and it looks good!

@Benbentwo Benbentwo merged commit d4d4b83 into cloudposse:main Jun 11, 2024
5 checks passed
@oycyc
Copy link
Contributor Author

oycyc commented Jun 11, 2024

Thanks!

goruha pushed a commit to cloudposse-terraform-components/aws-aurora-postgres that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants