[alb-controller] Make default_ingress_ip_address_type default to ipv4
#1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korenyoni
approved these changes
Jun 20, 2024
goruha
pushed a commit
to cloudposse-terraform-components/aws-eks-alb-controller
that referenced
this pull request
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
default_ingress_ip_address_typedefault toipv4why
When
dualstackis configured, the Ingress will fail if the VPC does not have an IPv6 CIDR block, which is still a common case. Whenipv4is configured, the Ingress will work with only an IPv4 CIDR block, and simply will not use IPv6 if it exists. This makesipv4themore conservative default.