Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kms): updates with embedded policy creation - part2 #1136

Merged
merged 13 commits into from
Nov 6, 2024
Merged

feat(kms): updates with embedded policy creation - part2 #1136

merged 13 commits into from
Nov 6, 2024

Conversation

Gowiem
Copy link
Member

@Gowiem Gowiem commented Oct 3, 2024

what

  • Updates the KMS module to support embedded policy creation

why

  • This allows for easy wiring in of aws-team-role roles into the KMS policy, so we do something like "Admins in the dev account have access to use this Key"

references

@Gowiem Gowiem requested review from a team as code owners October 3, 2024 02:02
@Gowiem Gowiem mentioned this pull request Oct 3, 2024
Closed
nitrocode
nitrocode reviewed Oct 3, 2024
View reviewed changes
modules/kms/README.md Outdated Show resolved Hide resolved
@nitrocode
Copy link
Member

Thanks for addressing all the changes @Gowiem. Feel free to ignore my comments as I do not have review power here. I got the @ sign notification so thought I'd re-review.

Benbentwo
Benbentwo approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@Benbentwo Benbentwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good, think we can make the policies tighter or customizable as a future enhancement.

@goruha
Copy link
Member

goruha commented Nov 6, 2024

@Benbentwo, we need to address all PRs before codefreeze. So, I liberate the criteria

@goruha goruha merged commit 8b6a602 into cloudposse:main Nov 6, 2024
4 checks passed
goruha added a commit to cloudposse-terraform-components/aws-kms that referenced this pull request Nov 27, 2024
@Gowiem @goruha
feat(kms): updates with embedded policy creation - part2 (cloudposse/…
e16153d 
…terraform-aws-components#1136)

Co-authored-by: Igor Rodionov <goruha@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode left review comments

@goruha goruha goruha approved these changes

@Benbentwo Benbentwo Benbentwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gowiem @nitrocode @goruha @Benbentwo