Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time_restriction support to team_routing_rule #27

Merged
merged 18 commits into from
Jan 3, 2022
Merged

time_restriction support to team_routing_rule #27

merged 18 commits into from
Jan 3, 2022

Conversation

Benbentwo
Copy link
Member

what

  • Adds Time_Restriction to team_routing_rule

why

  • Follow the sun model requires this

references

@Benbentwo Benbentwo requested review from a team as code owners December 22, 2021 00:33
aknysh
aknysh reviewed Dec 22, 2021
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

Benbentwo
Benbentwo commented Dec 22, 2021
View reviewed changes
modules/team_routing_rule/main.tf Outdated Show resolved Hide resolved
modules/team_routing_rule/main.tf Outdated Show resolved Hide resolved
modules/team_routing_rule/main.tf Show resolved Hide resolved
modules/team_routing_rule/main.tf Outdated Show resolved Hide resolved
nitrocode
nitrocode previously approved these changes Dec 30, 2021
View reviewed changes
@mergify mergify bot dismissed nitrocode’s stale review December 30, 2021 23:00

This Pull Request has been updated, so we're dismissing all reviews.

nitrocode
nitrocode previously approved these changes Dec 30, 2021
View reviewed changes
@nitrocode
Copy link
Member

/test all

aknysh
aknysh previously requested changes Dec 31, 2021
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

nitrocode and others added 3 commits December 31, 2021 01:47
@nitrocode @aknysh
Update modules/team_routing_rule/README.md
3cba8fc 
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
@nitrocode @aknysh
Update modules/team_routing_rule/main.tf
b995560 
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
@nitrocode @aknysh
Update modules/team_routing_rule/main.tf
14611f2 
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
@mergify mergify bot dismissed stale reviews from nitrocode and aknysh December 31, 2021 06:47

This Pull Request has been updated, so we're dismissing all reviews.

nitrocode and others added 8 commits December 31, 2021 01:47
@nitrocode @aknysh
Update modules/team_routing_rule/main.tf
03e257d 
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
@nitrocode @aknysh
Update modules/team_routing_rule/main.tf
409b60a 
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
@nitrocode @aknysh
Update modules/team_routing_rule/main.tf
00d4e58 
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
@nitrocode @aknysh
Update modules/team_routing_rule/main.tf
019c37a 
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
@nitrocode @aknysh
Update modules/team_routing_rule/main.tf
ac58e78 
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
@nitrocode @aknysh
Update modules/team_routing_rule/main.tf
a38142f 
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
@nitrocode @aknysh
Update modules/team_routing_rule/main.tf
5f3c7bd 
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
@nitrocode @aknysh
Update modules/team_routing_rule/main.tf
a11f790 
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
@nitrocode
Copy link
Member

/test all

@nitrocode nitrocode requested a review from aknysh December 31, 2021 06:49
@nitrocode nitrocode added the patch A minor, backward compatible change label Jan 3, 2022
@nitrocode nitrocode merged commit 088dfa5 into master Jan 3, 2022
@nitrocode nitrocode deleted the feature/time_restriction branch January 3, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@nitrocode nitrocode nitrocode left review comments

@adamcrews adamcrews Awaiting requested review from adamcrews adamcrews was automatically assigned from cloudposse/contributors

@woz5999 woz5999 Awaiting requested review from woz5999 woz5999 was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Benbentwo @nitrocode @aknysh @cloudpossebot