fix: Reset logger context when streaming logs from plugins #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
requested review from
a team and
marianogappa
and removed request for
ronsh12 and
a team
marianogappa
approved these changes
Oct 22, 2024
disq
approved these changes
Oct 22, 2024
5 tasks
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
🤖 I have created a release *beep* *boop* --- ## [1.24.1](v1.24.0...v1.24.1) (2024-10-22) ### Bug Fixes * Reset logger context when streaming logs from plugins ([#421](#421)) ([608e08a](608e08a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
kodiakhq bot
pushed a commit
to cloudquery/plugin-sdk
that referenced
this pull request
Oct 22, 2024
Fixes cloudquery/cloudquery-issues#2627 The wrong value in the `module` field is because of the bug fixed in cloudquery/plugin-pb-go#421 ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes https://github.com/cloudquery/cloudquery-issues/issues/2624 (internal issue)
We were using the logger created here https://github.com/cloudquery/cloudquery/blob/69143a73499660db2ab714781a5d207884fb9303/cli/cmd/logging.go#L51 to output logs messages from plugins. Plugins already set their log context in https://github.com/cloudquery/plugin-sdk/blob/8b9e067af19604d90d2e77d6e1aff1d93adad752/plugin/plugin.go#L213 and https://github.com/cloudquery/plugin-sdk/blob/8b9e067af19604d90d2e77d6e1aff1d93adad752/plugin/plugin.go#L241, so when we stream them to the
cloudquery.logfile we should use a new logger with an empty context.Use the following steps to ensure your PR is ready to be reviewed
go fmt ./...to format your code 🖊golangci-lint run🚨 (install golangci-lint here)