Miscellaneous PR feedback.

cloudscape-design · Nov 14, 2023 · 5318e3e · 5318e3e
1 parent a9b5505
commit 5318e3e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 49 deletions.
diff --git a/.stylelintrc b/.stylelintrc
@@ -53,51 +53,7 @@
     {
       "files": ["./src/button/*.scss"],
       "rules": {
-        "property-disallowed-list": [
-          "border", 
-          "border-bottom",
-          "border-bottom-color",
-          "border-bottom-left-radius",
-          "border-bottom-right-radius",
-          "border-bottom-width",
-          "border-bottom-style",
-          "border-left",
-          "border-left-color",
-          "border-left-width",
-          "border-left-style",
-          "border-radius",
-          "border-right", 
-          "border-right-color",
-          "border-right-width",
-          "border-right-style",
-          "border-top",
-          "border-top-color",
-          "border-top-left-radius",
-          "border-top-right-radius",
-          "border-top-width",
-          "border-top-style",
-          "border-style",
-          "bottom",
-          "height",
-          "left",
-          "margin",
-          "margin-bottom",
-          "margin-left",
-          "margin-right",
-          "margin-top", 
-          "max-height",
-          "max-width",
-          "min-height",
-          "min-width",
-          "padding",
-          "padding-bottom",
-          "padding-left",
-          "padding-right",
-          "padding-top",
-          "right",
-          "top",
-          "width"
-        ],
+        "property-disallowed-list": ["border", "border-radius", "border-style", "margin", "padding"],
         "csstools/use-logical": "always"
       }
     }

diff --git a/src/button/styles.scss b/src/button/styles.scss
@@ -98,7 +98,8 @@
   }
 
   &.button-no-text {
-    padding-inline: awsui.$space-button-icon-only-horizontal;
+    padding-inline-start: awsui.$space-button-icon-only-horizontal;
+    padding-inline-end: awsui.$space-button-icon-only-horizontal;
   }
 
   &.button-no-wrap {
@@ -115,7 +116,8 @@
   &.variant-flashbar-icon {
     // Icon has vertical padding, but no horizontal, we need to conpensate this
     // in order to have equal height and width
-    padding-inline: awsui.$space-xxs;
+    padding-inline-start: awsui.$space-xxs;
+    padding-inline-end: awsui.$space-xxs;
   }
 
   &.variant-modal-dismiss {
@@ -125,7 +127,8 @@
   }
 
   &.variant-inline-icon {
-    padding-block: 0;
+    padding-block-start: 0;
+    padding-block-end: 0;
     border-block: 0;
     border-inline: 0;
   }
@@ -145,7 +148,8 @@
   }
 
   &.button-no-text > .icon {
-    margin-inline: auto;
+    margin-inline-start: auto;
+    margin-inline-end: auto;
     // IE does not understand `initial`
     inset-inline: 0;
   }