This repository has been archived by the owner on Mar 16, 2022. It is now read-only.
Add initial node support TCK implementation #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not having any luck with the Travis build, keeps getting stuck without any progress at different points. |
pvlugter
force-pushed
the
node-support-tck
branch
from
a7e5dd3
to
5d1bfe0
Compare
jroper
pushed a commit
to jroper/cloudstate
that referenced
this pull request
Jan 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Begin to implement the new TCK for node support, starting with the event sourced TCK model. The node support event sourced implementation doesn't emit events immediately, so this currently applies the event handler to the command-local state as well, so the updated state can be returned in the response. And because events are not emitted immediately, there's no need to add the restart option for emit-then-fail, so the TCK is updated to test failures with or without the restart. See also #375.
I'll follow up later with the other TCK models, publishing a docker image, enabling for native image TCK, and so on.