From 61d7636e4cbf663236aaae3fce7beee12f769ec3 Mon Sep 17 00:00:00 2001 From: Dave Dozier <2555178+dwdozier@users.noreply.github.com> Date: Fri, 15 Mar 2024 17:58:43 -0400 Subject: [PATCH] Remove linting of python files - Python tests are no longer used - Brew package manager and other OS distros including python may implement PEP 668 which marks base python environments as 'externally managed' https://peps.python.org/pep-0668/ - This can cause issues where none should exist when running the python linting process --- Makefile | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/Makefile b/Makefile index acb626e8..4fcb128f 100644 --- a/Makefile +++ b/Makefile @@ -27,7 +27,6 @@ subdirs += $(test_dir) .PHONY += help-text .PHONY += lint .PHONY += lint_fix -.PHONY += lint_python .PHONY += lint_rust .PHONY += lint_shell .PHONY += precommit @@ -94,19 +93,13 @@ fix: format lint_fix # apply formatting fixes to the working directory format: cargo fmt --all - python3 -m black . - ruff check . --fix taplo fmt help_text: @rm -rf $(shell ls examples/help-text/*) cargo xtask generate-help-text --verbose -lint: lint_shell lint_rust lint_python lint_toml - -lint_python: - python3 -m black --quiet --check . - ruff check . +lint: lint_shell lint_rust lint_toml lint_rust: cargo fmt --all -- --check @@ -121,7 +114,6 @@ lint_toml: # apply linting fixes lint_fix: cargo clippy --workspace --all-features --fix --allow-staged --allow-dirty -- -D warnings - python3 -m black . subdir_action: @for sd in $(subdirs) ; do \ @@ -158,10 +150,6 @@ else ifeq ($(os_name),Linux) else @echo "Did not install shellcheck" endif - python3 -m pip install --user --upgrade black yamllint ruff -ifeq ('',$(shell which ruff)) - $(error Need to add python packages to your PATH) -endif test: RUST_BACKTRACE=1 cargo xtest