Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: generate struct in common crate rather than its own crate #214

Merged
merged 1 commit into from
Nov 16, 2023
Merged

fix: generate struct in common crate rather than its own crate #214

merged 1 commit into from
Nov 16, 2023

Conversation

Millione
Copy link
Member

Prevent the common crate from depending on other crates to escape the cyclic dependencies.

@Millione Millione requested review from a team as code owners November 16, 2023 12:52
@Millione Millione merged commit 0d34a55 into cloudwego:main Nov 16, 2023
9 checks passed
@Millione Millione deleted the fix/cyclic branch April 10, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PureWhiteWu PureWhiteWu PureWhiteWu approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Millione @PureWhiteWu