Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document searching #39

Closed
6 of 7 tasks
Tracked by #69
cloverich opened this issue Aug 17, 2021 · 1 comment
Closed
6 of 7 tasks
Tracked by #69

Document searching #39

cloverich opened this issue Aug 17, 2021 · 1 comment

Comments

@cloverich
Copy link
Owner

cloverich commented Aug 17, 2021 •
edited
Loading

(Deferring before and after id to #34 )

Allow date - Github supports this via:
Screen Shot 2022-04-05 at 9 35 25 AM
@cloverich cloverich mentioned this issue Sep 23, 2021
Closed
@cloverich cloverich mentioned this issue Oct 7, 2021
Closed
13 tasks
@cloverich cloverich mentioned this issue Apr 5, 2022
Closed
cloverich added a commit that referenced this issue Apr 6, 2022
@cloverich
persist search in router history (#39)
bd6fc28 
- when searching documents sync the tokens to the router's history.
- load tokens from router history when documents mount, so navigating back to the documents view will persist the prior search
@cloverich cloverich changed the title Add search Document searching Apr 8, 2022
@cloverich cloverich mentioned this issue Jan 14, 2024
Merged
@cloverich
Copy link
Owner Author

As of 736611b, everything but the after: token is implemented. After reviewing, I realized the before: token handles most of the usual after cases since documents are always descending ordered (newest first). Cursor based pagination can use before: perhaps using ids instead of date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cloverich