Search by title, text, and before date #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add title: tag for searching by title - add text: tag for searching by raw text
- add before: token to support searching before a certain date - refactor TagSearchStore to be encapsulated by SearchStore; a proper refactor is due here - leave a few comments; start and end of this commit is 2 YEARS apart, will need to clean up once I am fully refreshed
- if in: token references a journal that does not exist, drop it from the UI to clarify its not being included in the search - clean up some comments / typos
cloverich
force-pushed
the
cloverich/shrug
branch
from
bff00b6 to
0c1358c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
title:search tagtext:tag. Search defaults to this if you don't search by anythingbefore:tagThis implements part of #39 and may fix #72
This is part of the overall Roadmap #69