Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade esbuild #149

Merged
merged 1 commit into from
Jan 29, 2024
Merged

upgrade esbuild #149

merged 1 commit into from
Jan 29, 2024

Conversation

cloverich
Copy link
Owner

@cloverich cloverich commented Jan 29, 2024

  • upgrades esbuild to latest version, as part of core dependencies review
  • incorporate lint into build step, and prefer yarn run build to calling ./build.sh directly
  • update README and some documentation (comments)

Had to refactor the prior esbuild callbacks to plugins, which was easy enough once I figured out what to look for. The build itself is a bit slower, but still acceptable. Definitely a few improvements left on the table:

  • Renderer code should use a live or hot reload server, instead of re-starting the electron process
  • Type checking could be more thoroughly integrated (fail the bundle), and faster (incremental? stateful process?)

Overall probably worth looking into third party libraries that have likely sorted this out well; now that the project is on the latest esbuild version that should be easier.

Likely the last batch of work I'll do as part of #118

- upgrades esbuild to latest version, as part of core dependencies review
- update README and some documentation (comments)
@cloverich cloverich merged commit 01371d9 into master Jan 29, 2024
1 check passed
@cloverich cloverich deleted the update-esbuild branch January 29, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant