flesh out and clean-up toolbar #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fleshes out remaining supported block types (paragraph, heading, etc) with a toggle / insert dropdown menu - Remove debug tabs (evergreen component) and replace with debug dropdown in toolbar - Some clean-up, commenting, re-naming of toolbar and debug related functions - Addition of read only editor view, just a shell for now
|
Doh. This closes #103 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It mostly works, but reveals a few other bugs (such as #171 ). I created a few associated Github issues to control scope.
This also removes the prior debug tabs, and converts it into a dropdown in the toolbar:
Originally I had intended to work on #128 , but realized I needed to be able to toggle regular headings, and understand some additional concepts that were related anyhow. Now I think better to flesh out all the core blocks first, before doing the more customized ones. Makes the editor more usable in a base sense anyways.