Add support for links, wysiwyg style #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- hack and half work but dont want to lose - has two static link menus for editing and viewing - view, edit, update, and remove links work - need paste to link, enter to submit, floating menu, polish, refactor and cleanup
- add paste to link selected text behavior - convert static menus to styled floating context menu - add aux click to inspect element debug helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#44
What a nightmare. See test cases which I tried to write out but did not have time to implement. Maybe if this reaches true MVP usability there will be time for that, and doing all the other things correctly!
This PR adds support for links, using a hover menu on focus similar to
This also includes some WIP markdown converting on paste (or maybe that was leftover from the images WIP) which will need reviewed and validated. Lots of stuff to do and test and improve, but good wysiwyg support is officially moving. Yay.