Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: plate migration #78

Merged
merged 7 commits into from
Oct 15, 2021
Merged

wip: plate migration #78

merged 7 commits into from
Oct 15, 2021

Conversation

cloverich
Copy link
Owner

@cloverich cloverich commented Oct 13, 2021

Wow lots of up and downs on this one. Had to fork remark-slate-transformer and customize it quite a bit. Could possibly abstract the details and PR it back but would take a little work.

  • using plate
  • image display
  • link display
  • marks
  • toolbar (its there, but needs styled better
  • image upload
  • clean up old code (slate plugins and such)
  • undo the sqlite3 rebuild change (Got tired of it running while constantly re-installing packages)
  • old custom links were better... consider going back
  • trailing paragraph
  • de-nest images to avoid validateDOMNesting warning
  • add code blocks

Implements #68 and a bunch of others like:

- add fix for images nested in paragraph tags
- add a test for the parse step, even though i cannot get it to run :|
- add a top-level ErrorBoundary
- update remark
- organize and refactor remark usage post upgrade
- clean-out a few other unused dependencies
@cloverich cloverich merged commit 4c8d54d into master Oct 15, 2021
@cloverich cloverich deleted the cloverich/plate-migration branch October 15, 2021 18:31
This was referenced Oct 15, 2021
@cloverich cloverich mentioned this pull request Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant