Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for ReactPHP Promise v3 #53

Closed
wants to merge 9 commits into from
Closed

Added support for ReactPHP Promise v3 #53

wants to merge 9 commits into from

Commits on Feb 23, 2021

  1. Added support for react/promise v3

    @davidcole1340
    davidcole1340 committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    c38cd2d View commit details
    Browse the repository at this point in the history

  2. CancellablePromiseInterface is an interface, not a class

    @davidcole1340
    davidcole1340 committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    6757d99 View commit details
    Browse the repository at this point in the history

  3. Changed the way promises were cancelled 

    See reactphp/promise#75 (comment)
    @davidcole1340
    davidcole1340 committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    ed86a7b View commit details
    Browse the repository at this point in the history

  4. Changed react/promise version to allow 3.0 and below

    @davidcole1340
    davidcole1340 committed Feb 23, 2021
    Configuration menu
    Copy the full SHA
    6430bad View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2021

  1. Change promise cancelling to be consistent with other React projects

    @davidcole1340
    davidcole1340 committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    a3fcb95 View commit details
    Browse the repository at this point in the history

  2. Reverted accidental test name change

    @davidcole1340
    davidcole1340 committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    c91da1f View commit details
    Browse the repository at this point in the history

  3. Added reasons when skipping tests for Promise v3

    @davidcole1340
    davidcole1340 committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    b38731c View commit details
    Browse the repository at this point in the history

  4. Create exceptions with strings as the message

    @davidcole1340
    davidcole1340 committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    96f3e35 View commit details
    Browse the repository at this point in the history

  5. Removed ::class modifier for <PHP 5.4 support

    @davidcole1340
    davidcole1340 committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    d3d5a36 View commit details
    Browse the repository at this point in the history