Allow gm fly command

[davidonete]

🍰 Pullrequest

Allow gm fly command, I believe it is very useful for debugging purposes.

[cpevors]

Classic doesn't have .gm fly on? TBC does. Further, in TBC, "jumping" doesn't cancel or remove the effect, i.e. Space/"jump" just causes the player to ascend in the air.

Should we not implement something analogous to TBC's command?

bool ChatHandler::HandleGMFlyCommand(char* args)
{
    bool value;
    if (!ExtractOnOff(&args, value))
    {
        SendSysMessage(LANG_USE_BOL);
        SetSentErrorMessage(true);
        return false;
    }

    Player* target = getSelectedPlayer();
    if (!target)
        target = m_session->GetPlayer();

    target->SetCanFly(value);
    PSendSysMessage(LANG_COMMAND_FLYMODE_STATUS, GetNameLink(target).c_str(), args);
    return true;
}

[killerwife]

Client doesnt fly in vanilla afaik. The packet doesnt exist. Have you actually tried this? :D

[davidonete]

yes I have, the only issue is if you jump, that's why I put that warning message. We do have it working in SPP

[insunaa]

@cpevors Vanilla has no concept of flying, that was a brand-new addition with TBC. Vanilla has swimming, which is analogous to flying, but in vanilla swimming you could jump underwater. They hadn't remapped jumping to "ascend" yet.
Jumping changes the character's moveflags to jumping/falling and so cancels the swimming moveflag. underwater that's fine, because when you land you land in water, which re-enables the swimming moveflag, but in air you just keep falling.

[cpevors]

The more you know. Appreciate the insights, everyone!

[celguar]

Vmangos has flying for ages, ofc it works

[celguar]

But not sure if changed here are enough for it

[cpevors]

In hindsight, I think VMaNGOS has a version of flying that also cancels on 'jump,' though.

From VMaNGOS:

bool ChatHandler::HandleCheatFlyCommand(char* args)
{
    bool value;
    if (!ExtractOnOff(&args, value))
    {
        SendSysMessage(LANG_USE_BOL);
        SetSentErrorMessage(true);
        return false;
    }

    Player* target = GetSelectedPlayer();
    if (!target)
        target = m_session->GetPlayer();

    target->SetCheatFly(value, true);

    PSendSysMessage(LANG_YOU_SET_FLY, value ? "on" : "off", GetNameLink(target).c_str());
    if (needReportToTarget(target))
        ChatHandler(target).PSendSysMessage(LANG_YOUR_FLY_SET, value ? "on" : "off", GetNameLink().c_str());

    if (value)
        ChatHandler(target).SendSysMessage("WARNING: Do not jump or flying mode will be removed.");

    return true;
}

[davidonete]

ouch, I missed some extra code, should be fine now

[ImmortalusDev]

In order to make it work you need to do more changes

[killerwife]

This code can be now as a result be called for non player entities. Your PR aims to add it for GM players, for anyone else due to shenanigans of someone trying to debug this, this is not good to have. Amend it to only be strictly callable for player pls.

[celguar]

gm fly on command is for target or self

[killerwife]

If I understand it correctly and has a similar issue like knockback in tbc, you would have to actually check jump packet and re-add flying moveflag forcibly every time that happens for this to work. Anyone can feel free to correct me.