Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mkFit to 2.0.1 #5213

Merged
merged 2 commits into from
Sep 9, 2019

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Sep 6, 2019

This PR updates mkFit to 2.0.1, which itself is a code-wise small update to have the same version whose performance will be presented on TRK POG meeting next Monday (Sep 9).

FYI @slava77 @mtosi @JanFSchulte

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2019

A new Pull Request was created by @makortel (Matti Kortelainen) for branch IB/CMSSW_11_0_X/gcc700.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Sep 6, 2019

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2412/console Started: 2019/09/06 20:45

mkfit-toolfile.spec Outdated Show resolved Hide resolved
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2019

Pull request #5213 was updated.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/2415/console Started: 2019/09/06 22:02

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 6, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-687302/2415/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2955796
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2955453
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 145 log files, 15 edm output root files, 34 DQM output files

@smuzaffar
Copy link
Contributor

+externals

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2019

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_11_0_X/gcc700 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Sep 9, 2019

+1

@cmsbuild cmsbuild merged commit d08657f into cms-sw:IB/CMSSW_11_0_X/gcc700 Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants