Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llvm] add zstd deps to make sure it is not picked up from system #9327

Merged
merged 1 commit into from
Jul 27, 2024

Conversation

smuzaffar
Copy link
Contributor

We build our software stack in containers where zstd package is not installed but on shared system e.g. riscv64 nodes zstd might be available on system and llvm then picks it up and linked against it. This change will allow to build llvm agaisnt out zstd

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_1_X/master.

@aandvalenzuela, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 27, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c56b7d/40649/summary.html
COMMIT: c4e68e6
CMSSW: CMSSW_14_1_X_2024-07-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9327/40649/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@smuzaffar
Copy link
Contributor Author

+externals

@smuzaffar smuzaffar merged commit ae11306 into IB/CMSSW_14_1_X/master Jul 27, 2024
9 checks passed
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

This was referenced Jul 29, 2024
@smuzaffar smuzaffar deleted the llvm-zstd-fix branch August 5, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants