-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace trackingPhase1PU70 workflows with CA seeding #16911
Changes from 4 commits
d48ae7c
f8204f7
aa18ba0
264cf7b
e66db97
8a86cb5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,7 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
from Configuration.Eras.Era_Run2_2016_cff import Run2_2016 | ||
from Configuration.Eras.ModifierChain_run2_2017_core_cff import run2_2017_core | ||
from Configuration.Eras.Modifier_trackingPhase1_cff import trackingPhase1 | ||
from Configuration.Eras.Modifier_run2_HE_2017_cff import run2_HE_2017 | ||
from Configuration.Eras.Modifier_run2_HF_2017_cff import run2_HF_2017 | ||
from Configuration.Eras.Modifier_run2_HCAL_2017_cff import run2_HCAL_2017 | ||
|
||
Run2_2017 = cms.ModifierChain(run2_2017_core, trackingPhase1) | ||
|
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
from Configuration.Eras.ModifierChain_run2_2017_core_cff import run2_2017_core | ||
from Configuration.Eras.Modifier_trackingPhase1QuadProp_cff import trackingPhase1QuadProp | ||
|
||
Run2_2017_trackingPhase1QuadProp = cms.ModifierChain(run2_2017_core, trackingPhase1QuadProp) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
from Configuration.Eras.ModifierChain_run2_2017_core_cff import run2_2017_core | ||
from Configuration.Eras.Modifier_trackingPhase1_cff import trackingPhase1 | ||
|
||
Run2_2017_trackingPhase1QuadProp = cms.ModifierChain(run2_2017_core, trackingPhase1) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
import FWCore.ParameterSet.Config as cms | ||
|
||
trackingPhase1QuadProp = cms.Modifier() |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -62,6 +62,8 @@ | |
) | ||
from Configuration.Eras.Modifier_trackingPhase1_cff import trackingPhase1 | ||
trackingPhase1.toModify(PixelSeedMergerQuadruplets, **_forPhase1) | ||
from Configuration.Eras.Modifier_trackingPhase1QuadProp_cff import trackingPhase1QuadProp | ||
trackingPhase1QuadProp.toModify(PixelSeedMergerQuadruplets, **_forPhase1) | ||
from Configuration.Eras.Modifier_trackingPhase1PU70_cff import trackingPhase1PU70 | ||
trackingPhase1PU70.toModify(PixelSeedMergerQuadruplets, **_forPhase1) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is the trackingPhase1PU70 going to go away in a follow-up cleanup commit? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I will remove |
||
from Configuration.Eras.Modifier_trackingPhase2PU140_cff import trackingPhase2PU140 | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,6 +21,10 @@ | |
trackingPhase1.toModify(detachedQuadStepSeedLayers, | ||
layerList = RecoPixelVertexing.PixelTriplets.quadrupletseedmerging_cff.PixelSeedMergerQuadruplets.layerList.value() | ||
) | ||
from Configuration.Eras.Modifier_trackingPhase1QuadProp_cff import trackingPhase1QuadProp | ||
trackingPhase1QuadProp.toModify(detachedQuadStepSeedLayers, | ||
layerList = RecoPixelVertexing.PixelTriplets.quadrupletseedmerging_cff.PixelSeedMergerQuadruplets.layerList.value() | ||
) | ||
from Configuration.Eras.Modifier_trackingPhase2PU140_cff import trackingPhase2PU140 | ||
trackingPhase2PU140.toModify(detachedQuadStepSeedLayers, | ||
layerList = RecoPixelVertexing.PixelTriplets.quadrupletseedmerging_cff.PixelSeedMergerQuadruplets.layerList.value() | ||
|
@@ -79,6 +83,22 @@ | |
fitFastCircle = True, | ||
fitFastCircleChi2Cut = True, | ||
) | ||
from RecoPixelVertexing.PixelTriplets.caHitQuadrupletEDProducer_cfi import caHitQuadrupletEDProducer as _caHitQuadrupletEDProducer | ||
trackingPhase1.toModify(detachedQuadStepHitDoublets, layerPairs = [0,1,2]) # layer pairs (0,1), (1,2), (2,3) | ||
trackingPhase1.toReplaceWith(detachedQuadStepHitQuadruplets, _caHitQuadrupletEDProducer.clone( | ||
doublets = "detachedQuadStepHitDoublets", | ||
extraHitRPhitolerance = detachedQuadStepHitTriplets.extraHitRPhitolerance, | ||
maxChi2 = dict( | ||
pt1 = 0.8, pt2 = 2, | ||
value1 = 500, value2 = 100, | ||
), | ||
useBendingCorrection = True, | ||
fitFastCircle = True, | ||
fitFastCircleChi2Cut = True, | ||
CAThetaCut = 0.0011, | ||
CAPhiCut = 0, | ||
)) | ||
|
||
from RecoPixelVertexing.PixelTriplets.pixelQuadrupletMergerEDProducer_cfi import pixelQuadrupletMergerEDProducer as _pixelQuadrupletMergerEDProducer | ||
from RecoPixelVertexing.PixelTriplets.quadrupletseedmerging_cff import * | ||
_detachedQuadStepHitQuadrupletsMerging = _pixelQuadrupletMergerEDProducer.clone( | ||
|
@@ -441,6 +461,7 @@ | |
detachedQuadStepTracks* | ||
detachedQuadStepClassifier1*detachedQuadStepClassifier2* | ||
detachedQuadStep) | ||
trackingPhase1.toReplaceWith(DetachedQuadStep, DetachedQuadStep.copyAndExclude([detachedQuadStepHitTriplets])) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. since this is now the default, better eventually migrate to DetachedQuadStep appropriate for CA setup There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You mean making the default in the file CA, and customize it to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes. |
||
_DetachedQuadStep_Phase1PU70 = DetachedQuadStep.copyAndExclude([detachedQuadStepClassifier1]) | ||
_DetachedQuadStep_Phase1PU70.replace(detachedQuadStepClassifier2, detachedQuadStepSelector) | ||
trackingPhase1PU70.toReplaceWith(DetachedQuadStep, _DetachedQuadStep_Phase1PU70) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a spurious file or is it buggy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spurious file, thanks for catching.