Make it possible to use the fourth hit of a pixel track in SeedGeneratorFromProtoTracksEDProducer

[makortel]

PR description:

This PR is an updated version of #26322 where a configuration parameter includeFourthHit is added to SeedGeneratorFromProtoTracksEDProducer to control whether the fourth of the pixel track is included in the seed or not. The parameter default is set to False so this PR should have no effect. The main motivation for the change is to be able to test mkFit within a customized HLT menu (as of today mkFit needs 4-hit seeds).

PR validation:

Limited matrix runs.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28473/12914

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

RecoTracker/TkSeedGenerator

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3632/console Started: 2019/11/26 03:15

[cmsbuild]

+1
Tested at: 881e353
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cb52ed/3632/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cb52ed/3632/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2787584
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2787242
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[slava77]

+1

for #28473 881e353

• code changes are in line with the PR description; this is an expected resolution to the discussion leading from the performance analysis in Use also the fourth hit of pixel track in SeedGeneratorFromProtoTracksEDProducer #26322.
  • Based on the HLT seeding (pixel track reco) developments from PATATRACK, I think that this is needed for a general HLT development. Recall that the run2 pixel tracks in HLT have a worse quality and this 4th hit enabled by default lead to some performance degradation due to using all hits from the seed directly. I expect that the patatrack pixel seeds will be much better and quite likely we can use all hits as is without re-passing [the last hit] the data to the pattern recognition.
• jenkins tests pass and comparisons with the baseline show no differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1