-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SiStrip Payload Inspector: alternative style Tracker Maps and code clean-up #32530
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32530/20481
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages: CondCore/SiStripPlugins @ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e44bb3/11775/summary.html Comparison SummarySummary:
|
@cmsbuild, please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32530/20512
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e44bb3/11803/summary.html DAS Queries failed Comparison SummarySummary:
|
b7d539b
to
1c97e5f
Compare
code-checks |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32530/20555
|
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e44bb3/11839/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR adds the possibility to produce and display Tracker Maps of the SiStrip detector conditions using
TH2Poly
and theTPolyLine
vertices stored as externals (in thecms-data/DQM-SiStripMonitorClient
repository) in this PR: cms-data/DQM-SiStripMonitorClient#1 via the newly introduced classSiStripTkMaps
.A couple of examples are implemented as well.
I profit of this PR to introduce a couple of clean-up commits:
cond::payloadInspector
in allCondCore/SiStripPlugins
in all plugins avoiding heavy repetitions in the code.PR validation:
Relies on private validation and augmented unit tests.
A couple of example outputs are pasted here:
if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is not a backport and no backport is needed.