Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SiStrip Payload Inspector: alternative style Tracker Maps and code clean-up #32530

Merged
merged 12 commits into from
Dec 23, 2020

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Dec 17, 2020

PR description:

This PR adds the possibility to produce and display Tracker Maps of the SiStrip detector conditions using TH2Poly and the TPolyLine vertices stored as externals (in the cms-data/DQM-SiStripMonitorClient repository) in this PR: cms-data/DQM-SiStripMonitorClient#1 via the newly introduced class SiStripTkMaps .
A couple of examples are implemented as well.
I profit of this PR to introduce a couple of clean-up commits:

  • 5bf3100 migrates wherever possible to the new PayloadInspector class interfaces introduced at PR Improvements for Payload inspector #29622
  • c0ff2c5 makes use of the namespace cond::payloadInspector in all CondCore/SiStripPlugins in all plugins avoiding heavy repetitions in the code.

PR validation:

Relies on private validation and augmented unit tests.
A couple of example outputs are pasted here:

LAMap

BCMap

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport and no backport is needed.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32530/20481

  • This PR adds an extra 48KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/SiStripPlugins

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich, @VinInn this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Dec 17, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e44bb3/11775/summary.html
CMSSW: CMSSW_11_3_X_2020-12-17-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2747287
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2747255
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 153 log files, 37 edm output root files, 36 DQM output files

@mmusich
Copy link
Contributor Author

mmusich commented Dec 18, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32530/20512

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #32530 was updated. @ggovi can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e44bb3/11803/summary.html
CMSSW: CMSSW_11_3_X_2020-12-18-1100/slc7_amd64_gcc900

DAS Queries failed

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2716967
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2716932
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 153 log files, 37 edm output root files, 36 DQM output files

@cmsbuild
Copy link
Contributor

Pull request #32530 was updated. @ggovi, @cmsbuild can you please check and sign again.

@mmusich mmusich changed the title SiStrip Payload Inspector: alternative style Tracker Maps SiStrip Payload Inspector: alternative style Tracker Maps and code clean-up Dec 22, 2020
@mmusich
Copy link
Contributor Author

mmusich commented Dec 22, 2020

code-checks

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32530/20555

  • This PR adds an extra 56KB to repository

@cmsbuild
Copy link
Contributor

Pull request #32530 was updated. @ggovi, @cmsbuild can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Dec 22, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e44bb3/11839/summary.html
CMSSW: CMSSW_11_3_X_2020-12-22-1100/slc7_amd64_gcc900

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2716967
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2716938
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 35 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 153 log files, 37 edm output root files, 36 DQM output files

@ggovi
Copy link
Contributor

ggovi commented Dec 22, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 23, 2020

+1

@cmsbuild cmsbuild merged commit e678eaf into cms-sw:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants